[fw-auth] Re: [zf-contributors] Re: [fw-auth] Re: [zf-contributors] Feedback on Zend_Auth_Adapter_Flexible?

Hello!

Just thought I'd let y'all know that I've made a significant overhaul to my original proposal (now at http://framework.zend.com/wiki/display/ZFPROP/Zend_Controller_Action_Helper_AuthSelector+-+Adam+Jensen), reflecting what we discussed yesterday.  I think it's a lot clearer now, but I'm open to any further suggestions.  Thanks again for your help!

Adam

On Wed, Sep 16, 2009 at 7:36 PM, Adam Jensen <jazzslider@gmail.com> wrote:

Thank you both for your feedback on this; I'll be adjusting the proposal to reflect the new action helper approach as soon as I can.  Seems like that's a better fit, and I'm happy to make the necessary changes.

Thanks!

Adam

On Wed, Sep 16, 2009 at 9:44 AM, Ralph Schindler <ralph.schindler@zend.com> wrote:

All that said, I'm starting to wonder if my proposal might work better as an
action helper, since the main benefit is the simplification of controller
logic?  It may be more complicated than that, but it's probably worth some
thought; any ideas?

This sounds like application logic in many ways -- even the forms would
differ for each in some cases (OpenID would require a URL only; LDAP and/or
DbTable would require user/pass, etc.). This sounds like several

The form part could be handled userland, but yes, an action helper that
takes the form input and does the adapter delegation makes sense.

I'd like to see you explore the controller/action-helper route. Currently, there is not much in the way of helpers or plugins that aid Zend_Auth in "coupling" with an applications AuthController.

Much like the viewRenderer helps the controller's job of interacting with Zend_View, I think it makes alot of sense to have something like, say, "authSelector" to help decide and load various pieces to the authentication puzzle: forms, views, form helpers, and finally actual auth adapter.

While, the term "flexible" is good, I think we need to find something more succinct that will, by name, identify its job to the developer immediately.  Since you haven't gotten many comments on the original proposal, I can only guess that the naming is not something developers are immediately drawn to as its name does not conjure up any visions of what job it actually does.

Looking forward to your feedback now that I have a better grasp on what it is you are attempting to do!

-ralph