> Thank you for reporting this. The "," in the float value must be due to
> your different locale setting.
Probably yes, i didn't investigate this to deep. Casting float to
string solves problem quickly and easy without time consuming locale
recognition and conversion. In my opinion this can be case to thing for
Zend_Json_Encoder and/or Zend_Wildfire_Protocol_JsonStream developers.
> I like the addition of the number of queries and total time as well.
> However I would not append it to the end.
>
> Lets insert it into the label wherever we find certain placeholders.
>
> 'All DB Queries (%totalCount% - %totalDuration%)
>
> What do you think?
Again - my solution is fast and easy. Ofcourse can pass some kind of
"template" by Zend_Db_Profiler_Firebug constructor parameter, but, there
are only 2 variables to replace (i didn't see place for any more useful
informations for profiler label) and then we will have another time
consuming str_replace or regexp, and forcing users to remember this
variable names.
But, thees are only my opinions. As always, final decision is up for ZF
team :)
--
K.
没有评论:
发表评论